[Tux3] [PATCH] tux3: fix compile error in linus-git

OGAWA Hirofumi hirofumi at mail.parknet.co.jp
Wed Jan 7 11:02:00 PST 2009


OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:

>> COW credential was added after 2.6.28. And we shouldn't add needless #ifdef.
>> [BTW, if we really want to do this, we should add compat layer like
>> compat.h of external network drivers.]
>>
>> Thanks.
>
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,28)
>                      ^^^^^^
> +#define current_fsuid()	({ current->fsuid; })
> +#define current_fsgid()	({ current->fsgid; })
>  #endif
>
> Ugh, this should be <= obviously.
>
> +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,28)

#ifndef current_fsuid
...
#endif

is better. I'll re-send final version.

[BTW, the update for new version needs more change. With this, tux3
would work. However, newly found bugs fixes have to apply.]
-- 
OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://mailman.tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list