[Tux3] [PATCH] tux3: fix compile error in linus-git

OGAWA Hirofumi hirofumi at mail.parknet.co.jp
Wed Jan 7 10:46:09 PST 2009


OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:

> Daniel Phillips <phillips at phunq.net> writes:
>
>>> > Your patch breaks the user space compile because your macro definitions
>>> > appear outside the __KERNEL__ macro.  Could you try this version?
>>> 
>>> Yes, It is OK, and better than my version.
>>
>> OK, committed with credit to you.
>
> COW credential was added after 2.6.28. And we shouldn't add needless #ifdef.
> [BTW, if we really want to do this, we should add compat layer like
> compat.h of external network drivers.]
>
> Thanks.

+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,28)
                     ^^^^^^
+#define current_fsuid()	({ current->fsuid; })
+#define current_fsgid()	({ current->fsgid; })
 #endif

Ugh, this should be <= obviously.

+#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,28)
-- 
OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://mailman.tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list