[Tux3] kernel/ileaf.c fixes and cleanup

Daniel Phillips phillips at phunq.net
Mon Feb 23 17:21:58 PST 2009


On Monday 23 February 2009, OGAWA Hirofumi wrote:
> OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:
> 
> > Hi,
> >
> > I've found several bugs in kernel/ileaf.c. Even if all inodes on ileaf
> > was removed, we don't remove ileaf itself, at least for now.  So, we
> > have to handle empty ileaf, but in that case, some places is not
> > handling it correctly.
> >
> > And several cleanups.
> >
> > 	static-http://userweb.kernel.org/~hirofumi/tux3/
> >
> > I'm not reviewing those by myself, it is for the review. So, please
> > don't pull it yet.  However, with this patchset, it passes the fsstress
> > test more for a long time.
> 
> I've reviewed by myself, add some patches, and modified some patches
> slightly. With those, fsstress was passed for 9.5 hours.
> 
> And the one bug can be the cause of memory corruption. So, the problem
> which martin saw may be fixed.
> 
>  	static-http://userweb.kernel.org/~hirofumi/tux3/
> 
> The patches is also in the above place. Please review and pull.
> 
> Thanks.

Sorry for the slow review, I still have to recover from a couple of
sleepless nights.  It all looks good.  Next time... more review.  The
patches should get more interesting from here on as we move into the
atomic commit algorithms and asynchronous cache transfer.

Regards,

Daniel

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://mailman.tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list