[Tux3] [PATCH 02/10] don't use preallocation if BUFFER_PARANOIA_DEBUG is defined

OGAWA Hirofumi hirofumi at mail.parknet.co.jp
Sun Oct 19 02:27:35 PDT 2008


"Shapor Naghibzadeh" <shapor at gmail.com> writes:

>> The problem is - if dleaf doesn't have any group yet, dwalk_probe()
>> initialize the pointers by end of buffer. So, we can't do dereference
>> those pointers of dwalk, but some place does.
>>
>> I'm not reading all of dleaf stuff yet. So the patch may be wrong, or
>> there may be more good fix.
>> --
>> OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>
>>
>
> Yes, the change look correct to me.  I merged all your patches,

Thanks.

> inserting this one between 2 and 3 and all the tests passed after each
> one.  I also now have a semi-automated system for testing patches and
> patch sets posted to the list :)

That's great. Does it have (or plan) performance test too? I think, in
future performance regression also will become issue.
-- 
OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list