[Tux3] [PATCH 02/10] don't use preallocation if BUFFER_PARANOIA_DEBUG is defined

[Shapor Naghibzadeh]

On Fri, Oct 17, 2008 at 12:11 PM, OGAWA Hirofumi
<hirofumi at mail.parknet.co.jp> wrote:
> OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:
>
>> OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:
>>
>>> If buffer was allocated linearly, hard to detect invalid buffer access.
>>> So, don't use preallocation if BUFFER_PARANOIA_DEBUG is defined.
>>
>> BTW, with this, valgrind actually shows errors I don't check yet.
>
> The problem is - if dleaf doesn't have any group yet, dwalk_probe()
> initialize the pointers by end of buffer. So, we can't do dereference
> those pointers of dwalk, but some place does.
>
> I'm not reading all of dleaf stuff yet. So the patch may be wrong, or
> there may be more good fix.
> --
> OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>
>

Yes, the change look correct to me.  I merged all your patches,
inserting this one between 2 and 3 and all the tests passed after each
one.  I also now have a semi-automated system for testing patches and
patch sets posted to the list :)

Thanks again!

Daniel, can you pull from me? (at http://shapor.com/tux3/shapor-tux3)

Shapor

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://tux3.org/cgi-bin/mailman/listinfo/tux3