[Tux3] [PATCH 03/10] Fix ileaf aligment

[OGAWA Hirofumi]

OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:

> OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:
>
>> Daniel Phillips <phillips at phunq.net> writes:
>>
>>>> -struct ileaf { u16 magic, count; inum_t ibase; char table[]; };
>>>> +struct ileaf { u16 magic, count; u32 pad; inum_t ibase; char table[]; };
>>>>  
>>>>  /*
>>>>   * inode leaf format
>>>
>>> Good catch.  A better way to fix this is using gcc attribute packed,
>>> which is done by the Tux3 macro PACKED:
>>
>> But, I think the result of it is aliment fault on some archs.
>
> if we accessed ->ibase. Or we should use get_unaligned()?

Ah, and encode_* have to care about alignment too.
-- 
OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://tux3.org/cgi-bin/mailman/listinfo/tux3