[Tux3] [PATCH 03/10] Fix ileaf aligment

OGAWA Hirofumi hirofumi at mail.parknet.co.jp
Fri Oct 17 03:02:11 PDT 2008


OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> writes:

> Daniel Phillips <phillips at phunq.net> writes:
>
>>> -struct ileaf { u16 magic, count; inum_t ibase; char table[]; };
>>> +struct ileaf { u16 magic, count; u32 pad; inum_t ibase; char table[]; };
>>>  
>>>  /*
>>>   * inode leaf format
>>
>> Good catch.  A better way to fix this is using gcc attribute packed,
>> which is done by the Tux3 macro PACKED:
>
> But, I think the result of it is aliment fault on some archs.

if we accessed ->ibase. Or we should use get_unaligned()?
-- 
OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list