[FYI] tux3: Core changes

Rik van Riel riel at redhat.com
Tue May 26 14:36:45 PDT 2015


On 05/26/2015 04:22 PM, Daniel Phillips wrote:
> On 05/26/2015 02:00 AM, Jan Kara wrote:

>> So my opinion is: Don't fork the page if page_count is elevated. You can
>> just wait for the IO if you need stable pages in that case. It's slow but
>> it's safe and it should be pretty rare. Is there any problem with that?
> 
> That would be our fallback if anybody discovers a specific case where page
> fork breaks something, which so far has not been demonstrated.
> 
> With a known fallback, it is hard to see why we should delay merging over
> that. Perfection has never been a requirement for merging filesystems. On

However, avoiding data corruption by erring on the side of safety is
a pretty basic requirement.

> the contrary, imperfection is a reason for merging, so that the many
> eyeballs effect may prove its value.

If you skip the page fork when there is an elevated page count, tux3
should be safe (at least from that aspect). Only do the COW when there
is no "strange" use of the page going on.

-- 
All rights reversed



More information about the Tux3 mailing list