[PATCH 1/2] tux3: move TUX3_SUPER_MAGIC to magic.h

[Chao Yu]

Hi Daniel,

> -----Original Message-----
> From: Daniel Phillips [mailto:daniel at phunq.net]
> Sent: Wednesday, August 06, 2014 5:21 AM
> To: Chao Yu; phillips at phunq.net; hirofumi at mail.parknet.co.jp
> Cc: tux3 at phunq.net
> Subject: Re: [PATCH 1/2] tux3: move TUX3_SUPER_MAGIC to magic.h
> 
> Hi Chao,
> 
> Congratulations on your first Tux3 patch, and welcome to the team.

Thanks, I'm very glad to join this team, and I hope this patch could be a good start.

> 
> The basic form of this patch looks good, however, you are missing an explanation of the purpose
> of
> the patch, including how uapi will be using the Tux3 magic. Some of us know why, but it is better
> to
> explain under the assumption that nobody knows the purpose of this. A longer explanation is
> better.

Sorry about that.
For this patch, as near as I can tell, with magic.h, applications could recognize
the filesystem by the value which is gotten via statfs.
e.g. "stat -f" could get the magic value and translate the value to text, then
filesystem type could be shew to user.

Is there anything I am missing?

> 
> There are two different subsystems being touched here, so it should be two patches, each with
> its
> own explanation, not a patch series.

I'm not quite clear about the two different subsystems that you mentioned.
Could you please explain more about this?

You mean that we should split this patch into two to conform to the different
subsystems?

> 
> Just clean up and repost, no worries.
> 
> Regards,
> 
> Daniel
> 
> On 08/04/2014 02:29 AM, Chao Yu wrote:
> > This patch moves TUX3_SUPER_MAGIC to include/uapi/linux/magic.h
> >
> > Signed-off-by: Chao Yu <chao2.yu at samsung.com>
> > ---
> >  fs/tux3/super.c            | 5 -----
> >  include/uapi/linux/magic.h | 1 +
> >  2 files changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/fs/tux3/super.c b/fs/tux3/super.c
> > index 931c86d..c2cb4dc 100644
> > --- a/fs/tux3/super.c
> > +++ b/fs/tux3/super.c
> > @@ -12,11 +12,6 @@
> >  #include <linux/statfs.h>
> >  #include "kcompat.h"
> >
> > -/* This will go to include/linux/magic.h */
> > -#ifndef TUX3_SUPER_MAGIC
> > -#define TUX3_SUPER_MAGIC	0x74757833
> > -#endif
> > -
> >  #define trace trace_on
> >
> >  /* FIXME: this should be mount option? */
> > diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
> > index 77c6031..51f1e60 100644
> > --- a/include/uapi/linux/magic.h
> > +++ b/include/uapi/linux/magic.h
> > @@ -23,6 +23,7 @@
> >  #define XENFS_SUPER_MAGIC	0xabba1974
> >  #define EXT4_SUPER_MAGIC	0xEF53
> >  #define BTRFS_SUPER_MAGIC	0x9123683E
> > +#define TUX3_SUPER_MAGIC	0x74757833
> >  #define NILFS_SUPER_MAGIC	0x3434
> >  #define F2FS_SUPER_MAGIC	0xF2F52010
> >  #define HPFS_SUPER_MAGIC	0xf995e849