[Tux3] Tux3 report: Tux3 Git tree available

OGAWA Hirofumi hirofumi at mail.parknet.co.jp
Thu Mar 12 13:46:39 PDT 2009


Andrew Morton <akpm at linux-foundation.org> writes:

> On Fri, 13 Mar 2009 01:18:29 +0900
> OGAWA Hirofumi <hirofumi at mail.parknet.co.jp> wrote:
>
>> Andrew Morton <akpm at linux-foundation.org> writes:
>> 
>> > - When 'bh' is known to be non-NULL, use put_bh() rather than brelse().
>> 
>> It sounds strange. Almost all bh is non-NULL. This means we are going to
>> replace almost all brelse() by put_bh()?
>> 
>
> Well..  you can make up your own mind about this.  If you see benefit
> in the NULL-checking and extra debugging which brelse() provides then
> continue to use brelse().

I thought someone started to convert it. Ok, personally, I think
NULL-check is just not needed always, and if it is needed, check it
explicitly.
-- 
OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://mailman.tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list