[Tux3] [PATCH] tux3: fix compile error in linus-git

Daniel Phillips phillips at phunq.net
Wed Jan 7 12:30:03 PST 2009


On Wednesday 07 January 2009 07:25, OGAWA Hirofumi wrote:
> Daniel Phillips <phillips at phunq.net> writes:
> 
> >> > Your patch breaks the user space compile because your macro definitions
> >> > appear outside the __KERNEL__ macro.  Could you try this version?
> >> 
> >> Yes, It is OK, and better than my version.
> >
> > OK, committed with credit to you.
> 
> COW credential was added after 2.6.28. And we shouldn't add needless #ifdef.
> [BTW, if we really want to do this, we should add compat layer like
> compat.h of external network drivers.]
> 
> Thanks.

Gah, I checked the exact version of the change, then off-by-oned the
#if.

We will drop every "#if ... VERSION" before we start review.  New ones
are not arriving very fast.  As long as there are only a few they can
just go inline.

Regards,

Daniel


_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://mailman.tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list