[Tux3] logmap inode fix

Daniel Phillips phillips at phunq.net
Wed Jan 7 01:23:04 PST 2009


On Tuesday 06 January 2009 23:37, OGAWA Hirofumi wrote:
> Daniel Phillips <phillips at phunq.net> writes:
> 
> > The iattr passed here seem to be uninitialized:
> >
> > 	sbi->logmap = tux_new_inode(sbi->rootdir, &iattr, 0);
> >
> > Why not pass &(struct iattr){ }?
> 
> I think "static iattr" is more prefer, it would be in .bss, and it would
> be zeroed by initialization of program.

Ah, I overlooked the static.  Thanks, it looks good.

Daniel

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://mailman.tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list