[Tux3] Question on Tux3 Fuse

Tero Roponen tero.roponen at gmail.com
Thu Sep 25 08:10:55 PDT 2008


On Thu, 25 Sep 2008, Pranith Kumar wrote:

> 
> 
> On Thu, Sep 25, 2008 at 5:43 PM, Tero Roponen <tero.roponen at gmail.com> wrote:
>                      if ((errno = -ext2_readdir(dirfile, &(struct fillstate){ .dirent =
>       dirent }, tux3_filler)))
>                              return -errno;
> 
> Shouldn't this check be done in ext2_readdir itself?? I though that was the main purpose of
> calling
> ext2_readdir... to get any possible errors out of the way...
>       +               if (!*dirent)
>       +                       return -ENOENT;
>                      tux3_getattr(dirent, &stat);
>                      if (fuse_filler(buf, dirent, &stat, dirfile->f_pos)) {
>                              warn("fuse buffer full");
> 
> Pranith.

I think you are right, but I don't want to change anything
outside tux3fuse.c or tux3fs.c, because I am not familiar
with that code.
-------------- next part --------------
_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://tux3.org/cgi-bin/mailman/listinfo/tux3


More information about the Tux3 mailing list