[Tux3] Refactor filemap.c
phillips at phunq.net
Tue Dec 16 02:42:37 PST 2008
On Tuesday 16 December 2008 02:08, OGAWA Hirofumi wrote:
> > Instead of the loop over segs in tux3_get_block, we can just call with
> > max_segs = 1. I don't think there is a case where ->get_block can
> > handle more than one extent.
> Yes. However, we have 64 blocks limitation for one extent. So, caller
> may want to merge those to one extent. If get_segs merged those,
> get_block() will use max_segs=1 until it supports delayed write.
Yes, get_segs should merge those, and the dwalk_pack loop should break
them up again, which will sometimes give a better packing.
Tux3 mailing list
Tux3 at tux3.org
More information about the Tux3