[Tux3] [PATCH] rename and rmdir

Daniel Phillips phillips at phunq.net
Mon Dec 8 13:58:17 PST 2008

On Monday 08 December 2008 05:44, Pranith Kumar wrote:
> Hello,
> Sorry to hijack this but I cleaned it up for rmdir.

Nicely done!

Note: the 80 column rule for lindent was relaxed some time ago, so it
is ok to let lines go a little over if that improves readability.  I
followed up with a minor edit.

I converted tux_find_entry to use the ERR_PTR interface as an example
of how to do this.  We should use ERR_PTR more widely, particularly
in the blockget/blockread interface.  While doing this I spotted an
unhandled blockread error in tux_find_entry.



Tux3 mailing list
Tux3 at tux3.org

More information about the Tux3 mailing list