[Tux3] [PATCH] Fix maximum file size boundary checking. I added a test which attempts to

Daniel Phillips phillips at phunq.net
Thu Aug 28 09:20:14 PDT 2008


Merged.  Not that tuxread and tuxwrite really have to be in a loop like
generic_file_aio_read/write in kernel, which changes the limit checking
at little.  But your change heads in the right direction.  I will add
the loops pretty soon.  This isn't part of the filesystem itself unless
we want Tux3 to implement its own generic_file_* functions, which I do
not see a compelling reason for at this point.  Maybe after the initial
kernel port there will be a visible case for bypassing the generic_
library functions or maybe that is something that should be left for
later in the life of Tux3.  Anyway, we need a reasonable emulation of
file read/write in order to do realistic testing in userspace.

Short read/write is indeed the right thing to do when user hits the
maximimum file size.  The lower level checks in the filemap code are
redundant, they are actually cross checks against filesystem or vfs
bugs.

Regards,

Daniel

_______________________________________________
Tux3 mailing list
Tux3 at tux3.org
http://tux3.org/cgi-bin/mailman/listinfo/tux3



More information about the Tux3 mailing list